- This topic has 7 replies, 1 voice, and was last updated 2 months, 2 weeks ago by .
- Posts
How We Stopped Merging Pull Requests
Has been built-in gitlab for a long time lol
Isn’t this time wastage mitigated when GitHub automatically runs the tests on PRs? Some CI setups only run certain tests only on the main branch, but I find a good CI setups that runs on pushes and PRs to help a lot in PR workflows.
Code coverage bots (those that put a comment how much code coverage +/- is affected if the PR is merged) are also very helpful.
In Drupal, we have a bit that automatically tests an uploaded patch if the issue status is set to Needs Review, and the bot sets it to Needs Work if the tests fail. This way, the maintainer only needs to take a look at Needs Review tickets, and the contributor gets near I start feedback on their patches.
You can ignore the clickbait and go directly to [https://kodiakhq.com/](https://kodiakhq.com/)
I hope you are doing ok with that. I had bad experience with automatic merging on something that I didn’t read.
Why not merge the PR after the required reviewers have approved AND ci is green? Is that possible? I’m sure I would forget to add that Label.
Azure DevOps comes with automerging out of the box. So maybe Microsoft is going to port this to GitHub, since it is a really nice feature.
Sounds like a recipe for disaster. Test passing not always == working code.
- You must be logged in to reply to this topic.