How We Stopped Merging Pull Requests

Viewing 8 posts - 1 through 8 (of 8 total)
  • Author
    Posts
  • #1289
    Tomas_Votruba
    Participant

    How We Stopped Merging Pull Requests

    #1290
    EenAfleidingErbij
    Guest

    Has been built-in gitlab for a long time lol

    #1291
    ayeshrajans
    Guest

    Isn’t this time wastage mitigated when GitHub automatically runs the tests on PRs? Some CI setups only run certain tests only on the main branch, but I find a good CI setups that runs on pushes and PRs to help a lot in PR workflows.

    Code coverage bots (those that put a comment how much code coverage +/- is affected if the PR is merged) are also very helpful.

    In Drupal, we have a bit that automatically tests an uploaded patch if the issue status is set to Needs Review, and the bot sets it to Needs Work if the tests fail. This way, the maintainer only needs to take a look at Needs Review tickets, and the contributor gets near I start feedback on their patches.

    #1292
    1r0n1c
    Guest

    You can ignore the clickbait and go directly to [https://kodiakhq.com/](https://kodiakhq.com/)

    #1293
    kliin
    Guest

    I hope you are doing ok with that. I had bad experience with automatic merging on something that I didn’t read.

    #1294
    rswhite4
    Guest

    Why not merge the PR after the required reviewers have approved AND ci is green? Is that possible? I’m sure I would forget to add that Label.

    #1295
    Namoshek
    Guest

    Azure DevOps comes with automerging out of the box. So maybe Microsoft is going to port this to GitHub, since it is a really nice feature.

    #1296
    ThrowableHotPotato
    Guest

    Sounds like a recipe for disaster. Test passing not always == working code.

Viewing 8 posts - 1 through 8 (of 8 total)
  • You must be logged in to reply to this topic.